fix(logging): replace console.warn with logger in stars API route#3514
fix(logging): replace console.warn with logger in stars API route#3514badhra-ajaz wants to merge 1 commit intosimstudioai:mainfrom
Conversation
The stars API route used console.warn() for error logging while every other API route in the codebase uses createLogger from @sim/logger. This makes warning output from this route invisible to the structured logging pipeline. Replaced both console.warn() calls with logger.warn() to match the pattern used across all other API routes.
PR SummaryLow Risk Overview Written by Cursor Bugbot for commit 1de514b. This will update automatically on new commits. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
|
||
| if (!response.ok) { | ||
| console.warn('GitHub API request failed:', response.status) | ||
| logger.warn('GitHub API request failed:', response.status) |
There was a problem hiding this comment.
Production warnings silently suppressed by logger level filtering
Medium Severity
Switching from console.warn to logger.warn silently suppresses these warnings in production. The @sim/logger defaults to LogLevel.ERROR in production, so WARN-level messages are filtered out unless LOG_LEVEL is explicitly overridden. Previously, console.warn always emitted output. GitHub API failures and fetch errors will now go unnoticed in production logs.
Additional Locations (1)
Greptile SummaryThis PR replaces two Key observations:
Confidence Score: 4/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[GET /api/stars] --> B[fetch GitHub API]
B --> C{response.ok?}
C -- No --> D["logger.warn('GitHub API request failed:', status)"]
D --> E[Return fallback count]
C -- Yes --> F[Parse stargazers_count]
F --> G[Return formatted count]
B -- throws --> H["logger.warn('Error fetching GitHub stars:', error)"]
H --> E
style D fill:#ffe066,stroke:#e6b800
style H fill:#ffe066,stroke:#e6b800
subgraph logger["@sim/logger behavior"]
direction LR
L1[development → WARN ✅ logged]
L2[production → WARN ❌ suppressed by default]
L3[test → WARN ❌ suppressed]
end
D -.-> logger
H -.-> logger
Last reviewed commit: 1de514b |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| logger.warn('GitHub API request failed:', response.status) | ||
| return NextResponse.json({ stars: formatStarCount(19400) }) | ||
| } | ||
|
|
||
| const data = await response.json() | ||
| return NextResponse.json({ stars: formatStarCount(Number(data?.stargazers_count ?? 19400)) }) | ||
| } catch (error) { | ||
| console.warn('Error fetching GitHub stars:', error) | ||
| logger.warn('Error fetching GitHub stars:', error) |
There was a problem hiding this comment.
Warn-level logs are suppressed in production by default
The @sim/logger package sets minLevel: ERROR in production environments, which means both logger.warn() calls will be silently dropped in production unless a LOG_LEVEL env override is configured. Prior to this change, console.warn() always printed regardless of environment.
This means GitHub API failures — both non-OK responses and thrown exceptions — will be invisible in production logs by default. Consider whether these should be elevated to logger.error() to ensure they remain visible in production, or confirm that LOG_LEVEL=WARN is set in your production environment to preserve the previous behavior.
| logger.warn('GitHub API request failed:', response.status) | |
| return NextResponse.json({ stars: formatStarCount(19400) }) | |
| } | |
| const data = await response.json() | |
| return NextResponse.json({ stars: formatStarCount(Number(data?.stargazers_count ?? 19400)) }) | |
| } catch (error) { | |
| console.warn('Error fetching GitHub stars:', error) | |
| logger.warn('Error fetching GitHub stars:', error) | |
| logger.error('GitHub API request failed:', response.status) |
and
| logger.warn('GitHub API request failed:', response.status) | |
| return NextResponse.json({ stars: formatStarCount(19400) }) | |
| } | |
| const data = await response.json() | |
| return NextResponse.json({ stars: formatStarCount(Number(data?.stargazers_count ?? 19400)) }) | |
| } catch (error) { | |
| console.warn('Error fetching GitHub stars:', error) | |
| logger.warn('Error fetching GitHub stars:', error) | |
| logger.error('Error fetching GitHub stars:', error) |
1 participant
Problem
The
/api/starsroute usesconsole.warn()for error and failure logging, while every other API route in the codebase usescreateLoggerfrom@sim/logger. This means warning output from this route bypasses the structured logging pipeline.Before:
Fix
Replaced both
console.warn()calls withlogger.warn()using aStarsAPIlogger instance, matching the pattern used in all other API routes (e.g.,EnvironmentAPI,SkillsAPI,CreditsAPI).