fix: Preserve known CLI args when custom flags are present#5325
Open
realmeylisdev wants to merge 1 commit into
Open
fix: Preserve known CLI args when custom flags are present#5325realmeylisdev wants to merge 1 commit into
realmeylisdev wants to merge 1 commit into
Conversation
Closes serverpod#2396 ArgParser.parse throws on any unrecognised flag, which caused the catch block to null all fields — so --mode=production was silently discarded whenever a custom flag like --myCustomFlag was also passed. _filterKnownArgs now strips unknown tokens from the args list before handing it to the parser, so user-defined flags are ignored and all registered Serverpod options are parsed correctly. Known options with invalid values (e.g. --logging invalid) still trigger the catch and fall back to defaults as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2396
ArgParser.parsethrowsArgParserExceptionon any unrecognised flag or option. The catch block inCommandLineArgswas nulling all fields on any parse failure — so passing a custom flag like--myCustomFlagalongside--mode=productioncaused the server to silently start in development mode.Root cause
Fix
Added
_filterKnownArgs— a static helper that walks the raw token list and strips any flag or option theArgParserdoesn't know about, based onparser.options(so it's always in sync with the registered args). The filtered list is then passed toparse().--myCustomFlag) → silently ignored ✓--myCustomOption someValue) → silently ignored ✓--logging invalid) → still trigger the catch + fall back to defaults ✓Test plan
=-style syntax, and multiple known options mixed with multiple custom flags