Add defaults for cascading inherit fields and disable omitEmpty#687
Merged
J12934 merged 1 commit intosecureCodeBox:mainfrom Oct 1, 2021
EndPositive:cascading-inherit-fix
Merged
Add defaults for cascading inherit fields and disable omitEmpty#687J12934 merged 1 commit intosecureCodeBox:mainfrom EndPositive:cascading-inherit-fix
J12934 merged 1 commit intosecureCodeBox:mainfrom
EndPositive:cascading-inherit-fix
Conversation
Signed-off-by: Jop Zitman <jop.zitman@secura.com>
J12934
approved these changes
Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #683
Description
This PR, if applied, adds default values to the cascading inherit fields. Using
omitEmptyon booleans has an implicit default of omittingfalsevalues completely golang/go#13284. Since the cascading hook regardsinheritLabelsandinheritAnnotationsundefined field astrue, it was impossible to set those fields tofalse.secureCodeBox/hooks/cascading-scans/hook/hook.ts
Lines 161 to 165 in 79a279a
secureCodeBox/hooks/cascading-scans/hook/scan-helpers.ts
Lines 73 to 81 in 79a279a
Fixed by setting the default at CRD level with kubebuilders default annotation and deleting the
omitEmptytag.Results in all cascading scans to have the following fields by default:
inheritLabelsandinheritAnnotationstrueby default #334inheritEnvandinheritVolumesfalseby default #538 (comment)Checklist
npm testruns for the whole project.