Skip to content

Remove Old Teams Webhook#570

Merged
twwd merged 2 commits intomainfrom
maintenance/remove-teams-webhook
Aug 3, 2021
Merged

Remove Old Teams Webhook#570
twwd merged 2 commits intomainfrom
maintenance/remove-teams-webhook

Conversation

@JohannesZahn
Copy link
Contributor

@JohannesZahn JohannesZahn commented Aug 3, 2021 •
edited
Loading

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@JohannesZahn
delete teams-webhook directory
77916fd 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
adjust ci and package lock to teams webhook deletion
767197a 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn JohannesZahn self-assigned this Aug 3, 2021
@JohannesZahn JohannesZahn added breaking Changes requiring a major release ci Changes to the continuous integration setup hook Implement or update a hook maintenance labels Aug 3, 2021
@JohannesZahn JohannesZahn requested review from J12934 and nigthknight and removed request for nigthknight August 3, 2021 11:00
@JohannesZahn JohannesZahn marked this pull request as ready for review August 3, 2021 11:09
@JohannesZahn JohannesZahn requested a review from rfelber August 3, 2021 11:09
Weltraumschaf
Weltraumschaf approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@Weltraumschaf Weltraumschaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

twwd
twwd approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@twwd twwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@twwd twwd merged commit 4243474 into main Aug 3, 2021
@twwd twwd deleted the maintenance/remove-teams-webhook branch August 3, 2021 12:32
@JohannesZahn JohannesZahn mentioned this pull request Aug 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Weltraumschaf Weltraumschaf Weltraumschaf approved these changes

@twwd twwd twwd approved these changes

@J12934 J12934 Awaiting requested review from J12934

@nigthknight nigthknight Awaiting requested review from nigthknight

@rfelber rfelber Awaiting requested review from rfelber

Assignees

@JohannesZahn JohannesZahn

Labels

breaking Changes requiring a major release ci Changes to the continuous integration setup hook Implement or update a hook maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JohannesZahn @Weltraumschaf @twwd