Conversation
J12934
added
enhancement
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
…ing the url hardcoded in the config Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
This allows to keep all absolute urls out of the config. This can be used to define a single config for a set of simmilarly build services and only cahnge the url via the config args. Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com> Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
J12934
force-pushed
the
feature/zap-advanced-generic-configs
branch
from
a9ee4c0 to
73fc7e3
Compare
Signed-off-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
Signed-off-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
rfelber
approved these changes
Aug 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to completely configure the ZAP Advanced Scanners API Scans using Configs files with no absolute URLs in them. This can be very useful when scanning a large number of similarly crafted services where you don't want to define a config for each service. I've added a working example for this here: https://github.com/secureCodeBox/secureCodeBox/blob/feature/zap-advanced-generic-configs/scanners/zap-advanced/examples/demo-petstoreapi-scan-authenticated-no-hardcoded-urls/scan.yaml
To make this change somewhat easy I had to do a larger refactoring of the code base to (hopefully) simplify the config handling.