Name, Severity and Category are now required Findings attributes#557
Merged
Name, Severity and Category are now required Findings attributes#557
Conversation
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
JohannesZahn
added
persistence
J12934
reviewed
Jul 22, 2021
scanners/nmap/parser/parser.js
Outdated
| return openPorts.map(openPort => { | ||
| return { | ||
| name: openPort.service, | ||
| name: openPort.service || `Open Port: ${openPort.port}`, |
Member
There was a problem hiding this comment.
I would prefer to use the v3 release to make this more consistent and use the Open Port: ${openPort.port} format for all open port findings.
Maybe with the openPort.service appended in brackets if it exists:
like "Open Port: 8080 (http-apache)" or "Open Port: 10250"
Contributor
Author
There was a problem hiding this comment.
I implemented it, have a look at the recent changes
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
J12934
approved these changes
Jul 27, 2021
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #544
Checklist
npm testruns for the whole project.