Conversation
4fa9555 to
8ead0ef
Compare
ed3bd65 to
db690f8
Compare
db690f8 to
97ef56a
Compare
b53a889 to
6b968cb
Compare
|
Awesome 🚀 I think we should look into solutions to not have these Makefiles duplicated for every scanner once we start migrating the other scanners to this structure. Another thing which seems to be missing is that the test coverage of the unit test is not getting submitted to code climate, or did i miss that? @rseedorff can you look into why fossa / license scanner is failing? |
The basic structure of this Makefile should be used for all other scanners and hooks Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I had to add an empty `jest.config.js` files some scanners and hooks require specific configurations (e.g. for typescript) Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I excluded all `.tar` files that they don't end up in the docker context or the repo Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
To simplify building and deploying images for the operator locally I decided to add some targets to the Makefile Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
6b968cb to
8cdee92
Compare
I agree, but I did not find any leads yet. 👍
Good point. No, code coverage is currently not submitted to code climate for Makefile builds at the moment.
Are these issues resolved? At least, I don't see any issues with the checks on this PR. |
*.tarFiles