Skip to content

Add Makefile For Amass#551

Merged
J12934 merged 9 commits intomainfrom
makefile-amass
Jul 27, 2021
Merged

Add Makefile For Amass#551
J12934 merged 9 commits intomainfrom
makefile-amass

Conversation

@nigthknight
Copy link
Member

@nigthknight nigthknight commented Jul 20, 2021

@nigthknight nigthknight added ci Changes to the continuous integration setup maintenance scanner Implement or update a security scanner labels Jul 20, 2021
@nigthknight nigthknight self-assigned this Jul 20, 2021
@nigthknight nigthknight force-pushed the makefile-amass branch 7 times, most recently from 4fa9555 to 8ead0ef Compare July 20, 2021 11:44
@nigthknight nigthknight marked this pull request as draft July 20, 2021 12:00
@nigthknight nigthknight marked this pull request as ready for review July 20, 2021 12:27
@nigthknight nigthknight marked this pull request as draft July 20, 2021 12:40
@nigthknight nigthknight marked this pull request as ready for review July 21, 2021 15:20
@nigthknight nigthknight marked this pull request as draft July 26, 2021 06:42
@nigthknight nigthknight marked this pull request as ready for review July 26, 2021 07:15
@J12934
Copy link
Member

J12934 commented Jul 27, 2021

Awesome 🚀

I think we should look into solutions to not have these Makefiles duplicated for every scanner once we start migrating the other scanners to this structure.

Another thing which seems to be missing is that the test coverage of the unit test is not getting submitted to code climate, or did i miss that?

@rseedorff can you look into why fossa / license scanner is failing?
Or @fuhrmeistery do you have access to it? My fossa is still broken 😕

@nigthknight nigthknight disabled auto-merge July 27, 2021 07:32
The basic structure of this Makefile should be used for all other
scanners and hooks

Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I had to add an empty `jest.config.js` files some scanners and
hooks require specific configurations (e.g. for typescript)

Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I excluded all `.tar` files that they don't end up in the docker context
or the repo

Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
To simplify building and deploying images for the operator locally I
decided to add some targets to the Makefile

Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
@nigthknight
Copy link
Member Author

nigthknight commented Jul 27, 2021

I think we should look into solutions to not have these Makefiles duplicated for every scanner once we start migrating the other scanners to this structure.

I agree, but I did not find any leads yet. 👍

Another thing which seems to be missing is that the test coverage of the unit test is not getting submitted to code climate, or did i miss that?

Good point. No, code coverage is currently not submitted to code climate for Makefile builds at the moment.
I think regarding our plans to only execute Build Jobs for Code that has changes, we might run into some problems regarding codeclimate. Their documentation for configuring test coverage states that for parallel/multiple test/test-suits all test-suites need to be aggregated that codeclimate can combine them. Because codeclimate requires branch name and commit hash, we could run into trouble because we won't have coverage for everything in every commit.

@rseedorff can you look into why fossa / license scanner is failing?
Or @fuhrmeistery do you have access to it? My fossa is still broken confused

Are these issues resolved? At least, I don't see any issues with the checks on this PR.

@J12934 J12934 merged commit 62f0648 into main Jul 27, 2021
@J12934 J12934 deleted the makefile-amass branch July 27, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Changes to the continuous integration setup maintenance scanner Implement or update a security scanner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants