Skip to content

Self-close HTML Img Tags#541

Merged
twwd merged 2 commits intomainfrom
maintenance/fix-img-for-docs
Jul 13, 2021
Merged

Self-close HTML Img Tags#541
twwd merged 2 commits intomainfrom
maintenance/fix-img-for-docs

Conversation

@twwd
Copy link
Contributor

@twwd twwd commented Jul 13, 2021

Description

Adds the closing slashes to img HTML tags to prevent JSX syntax errors during the documentation build.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

Adds the closing slashes to `img` HTML tags to prevent JSX syntax
 errors during the documentation build.

Signed-off-by: Tim Walter <tim.walter@iteratec.com>
@twwd twwd force-pushed the maintenance/fix-img-for-docs branch from 280ad92 to 00ef5c6 Compare July 13, 2021 13:41
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
@twwd twwd requested a review from JohannesZahn July 13, 2021 13:43
@twwd twwd changed the title Self-close Image Tags Self-close HTML Img Tags Jul 13, 2021
Copy link
Contributor

@JohannesZahn JohannesZahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready to merge

@twwd twwd merged commit 0e27d5c into main Jul 13, 2021
@twwd twwd deleted the maintenance/fix-img-for-docs branch July 13, 2021 13:54
@rfelber rfelber added bug Bugs documentation Improvements or additions to documentation labels Aug 7, 2021
@rfelber rfelber added this to the v3.0.0 milestone Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants