Conversation
twwd
added
breaking
nigthknight
approved these changes
Jul 6, 2021
Contributor
Author
|
For cleaning up the remaining role, I create a dedicated MR. |
Renames `lurcher` to `lurker` to fix this long lasting typo. Signed-off-by: Tim Walter <tim.walter@iteratec.com>
Renames `lurcher` to `lurker` to fix this long lasting typo. Signed-off-by: Tim Walter <tim.walter@iteratec.com>
twwd
force-pushed
the
maintenance/rename-lurcher-to-lurker
branch
2 times, most recently
from
fc3329e to
06887f9
Compare
Signed-off-by: Tim Walter <tim.walter@iteratec.com>
Makes Codeclimate happy by extracting a method in Lurker's main.go to reduce the control flow nesting. Signed-off-by: Tim Walter <tim.walter@iteratec.com>
Adds the go module pkg/errors to `go.mod` since it is used in the Lurker's main.go. Signed-off-by: Tim Walter <tim.walter@iteratec.com>
Makes Codeclimate happy by extracting a method in Lurker's main.go to reduce the control flow nesting. Signed-off-by: Tim Walter <tim.walter@iteratec.com>
Makes Codeclimate happy by extracting the condition for the endless loop in Lurker's main.go to reduce the control flow nesting. Signed-off-by: Tim Walter <tim.walter@iteratec.com>
twwd
force-pushed
the
maintenance/rename-lurcher-to-lurker
branch
from
0c7e1ee to
6684a09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames
lurchertolurkerto fix this long lasting typo.Closes #535
Checklist
npm testruns for the whole project.