Skip to content

Add matched-finding id to cascading scan annotations#514

Merged
rfelber merged 5 commits intosecureCodeBox:mainfrom
EndPositive:cascading-scan-finding-id
Jul 3, 2021
Merged

Add matched-finding id to cascading scan annotations#514
rfelber merged 5 commits intosecureCodeBox:mainfrom
EndPositive:cascading-scan-finding-id

Conversation

@EndPositive
Copy link
Contributor

@EndPositive EndPositive commented Jun 22, 2021

Description

This PR introduces the annnotation cascading.securecodebox.io/matched-finding such that the finding for which the cascading scan was triggered can be identified (with the help of the cascading rules chain: cascading.securecodebox.io/chain).

Resolves #493.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@rfelber rfelber added enhancement New feature or request scanner Implement or update a security scanner labels Jul 3, 2021
@rfelber rfelber enabled auto-merge July 3, 2021 07:20
@rfelber rfelber changed the title Add matched-finding to cascading scan annotations Add matched-finding id to cascading scan annotations Jul 3, 2021
@rfelber rfelber disabled auto-merge July 3, 2021 07:25
@rfelber rfelber merged commit cff9af4 into secureCodeBox:main Jul 3, 2021
@EndPositive EndPositive deleted the cascading-scan-finding-id branch July 3, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request scanner Implement or update a security scanner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add matchedRule to cascading scans

2 participants