Add MS Teams Notifier To Notification Hook#513
Merged
nigthknight merged 12 commits intomainfrom Jul 9, 2021
Merged
Conversation
nigthknight
force-pushed
the
hook/teams-notifier
branch
from
1bdee92 to
a868cad
Compare
rfelber
requested changes
Jun 23, 2021
hooks/notification/notification-templates/msteams-messageCard.njk
Outdated
Show resolved
Hide resolved
hooks/notification/notification-templates/msteams-messageCard.njk
Outdated
Show resolved
Hide resolved
hooks/notification/notification-templates/msteams-messageCard.njk
Outdated
Show resolved
Hide resolved
nigthknight
force-pushed
the
hook/teams-notifier
branch
from
34db5a7 to
164c3e9
Compare
rfelber
previously requested changes
Jun 30, 2021
hooks/notification/notification-templates/msteams-messageCard.njk
Outdated
Show resolved
Hide resolved
hooks/notification/notification-templates/msteams-messageCard.njk
Outdated
Show resolved
Hide resolved
nigthknight
force-pushed
the
hook/teams-notifier
branch
from
fb48a8f to
b66b540
Compare
The implementation for a ms-teams notifier is nearly identical to the implementation of the slack notifier so I decided to create a new base class to handle Webhook Notifiers Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I had to update a test for NotifierFactory because it expected the creation of a Notifier type of MS_TEAMS to fail. Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
I wanted to render a nested template for a url containing a placeholder for an id Unfortunately I was not able to render this with the default setup so I decided to pass another object to the render function containing the Nunjucks function to render Strings Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
nigthknight
force-pushed
the
hook/teams-notifier
branch
from
b66b540 to
cca9d0b
Compare
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
J12934
approved these changes
Jul 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #318