Skip to content

Refactor hook HelmCharts to introduce consistency in HelmChart Values#484

Merged
J12934 merged 11 commits intosecureCodeBox:v3from
EndPositive:maintanance/helmchart-values-consistency-hooks
Jun 18, 2021
Merged

Refactor hook HelmCharts to introduce consistency in HelmChart Values#484
J12934 merged 11 commits intosecureCodeBox:v3from
EndPositive:maintanance/helmchart-values-consistency-hooks

Conversation

@EndPositive
Copy link
Contributor

@EndPositive EndPositive commented Jun 10, 2021

Description

This PR brings more consistency to hook HelmChart Values according to the spec described in #472.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
…Values table to readme

Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
@EndPositive EndPositive marked this pull request as draft June 10, 2021 09:28
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
@J12934 J12934 self-requested a review June 10, 2021 12:22
@J12934 J12934 added breaking Changes requiring a major release hook Implement or update a hook maintenance labels Jun 10, 2021
@J12934 J12934 added this to the v3.0.0 milestone Jun 10, 2021
@EndPositive EndPositive marked this pull request as ready for review June 10, 2021 14:12
@J12934 J12934 merged commit 47d0120 into secureCodeBox:v3 Jun 18, 2021
@EndPositive EndPositive deleted the maintanance/helmchart-values-consistency-hooks branch June 19, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Changes requiring a major release hook Implement or update a hook maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants