Refactor scanner HelmCharts to introduce consistency in HelmChart Values #483
Merged
J12934 merged 20 commits intosecureCodeBox:v3from Jun 9, 2021
EndPositive:maintanance/helmchart-values-consistency-scanners
Merged
Refactor scanner HelmCharts to introduce consistency in HelmChart Values #483J12934 merged 20 commits intosecureCodeBox:v3from EndPositive:maintanance/helmchart-values-consistency-scanners
J12934 merged 20 commits intosecureCodeBox:v3from
EndPositive:maintanance/helmchart-values-consistency-scanners
Conversation
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
…esTable to gotmpl Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Signed-off-by: Jop Zitman <jop-zitman@hotmail.com>
Contributor
Author
|
Should pass the integration tests. Is it possible to trigger them on this PR? |
Member
|
Not easily at the Moment. @fuhrmeistery is working on restructuring our ci so that it can run for external contributors. You can run the pipelines on your fork, but this won't mark them as passed in the pull request: https://github.com/secureCodeBox/secureCodeBox/blob/main/CONTRIBUTING.md#working-with-forks-and-pull-requests I'll take a look at the PR and merge it to a v3 branch in the repo, so the checks can run. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR brings more consistency to scanner HelmChart Values according to the spec described in #472.
Checklist
npm testruns for the whole project.