Skip to content

Make annotations on demo-apps configurable#467

Merged
J12934 merged 1 commit intomainfrom
feature/demo-apps-annotations
Jun 3, 2021
Merged

Make annotations on demo-apps configurable#467
J12934 merged 1 commit intomainfrom
feature/demo-apps-annotations

Conversation

@J12934
Copy link
Member

@J12934 J12934 commented Jun 3, 2021

Description

Add labels and annotations helm values to configure the labels on the demo-apps deployed via our helm-charts.

HttpWebhook already had a simmilar mechanism for podAnnotations, i marked it as deprecated to be removed in v3 as this would be confusing to have two separate mechanisms for it. I'll add it to the list in #293

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@J12934 J12934 added the enhancement New feature or request label Jun 3, 2021
@J12934 J12934 self-assigned this Jun 3, 2021
@J12934 J12934 force-pushed the feature/demo-apps-annotations branch from 7915145 to 7484c19 Compare June 3, 2021 08:52
@rfelber rfelber enabled auto-merge June 3, 2021 08:56
@rfelber rfelber added this to the v2.8.0 milestone Jun 3, 2021
@J12934 J12934 disabled auto-merge June 3, 2021 09:22
@J12934 J12934 merged commit a223449 into main Jun 3, 2021
@J12934 J12934 deleted the feature/demo-apps-annotations branch June 3, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants