🕸 Extend the Cascading-Scans Hook to generate custom labels or annotations for subsequent scans#430
Merged
rfelber merged 12 commits intosecureCodeBox:mainfrom May 23, 2021
EndPositive:cascading_scans_custom_annotations
Merged
🕸 Extend the Cascading-Scans Hook to generate custom labels or annotations for subsequent scans#430rfelber merged 12 commits intosecureCodeBox:mainfrom EndPositive:cascading_scans_custom_annotations
rfelber merged 12 commits intosecureCodeBox:mainfrom
EndPositive:cascading_scans_custom_annotations
Conversation
….scanLabels (without templating).
…ule.spec.scanLabels.
Member
|
Hi @EndPositive, |
Contributor
Author
|
Hey @rseedorff , no problemo! I'm planning to get it ready for review by tomorrow. If I have any more questions, I'll be sure to reach out! |
rfelber
reviewed
May 23, 2021
rfelber
reviewed
May 23, 2021
operator/config/crd/bases/cascading.securecodebox.io_cascadingrules.yaml
Show resolved
Hide resolved
rfelber
reviewed
May 23, 2021
rfelber
requested changes
May 23, 2021
Member
rfelber
left a comment
rfelber
left a comment
There was a problem hiding this comment.
Hi @EndPositive,
your PR looks great 👍🏻 To prevent a breaking change the scanAnnotations shouldn't be required.
Co-authored-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
Contributor
Author
|
Good catch, thanks! |
rfelber
approved these changes
May 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements some of the features described in #334 related to annotations and labels in cascading scans.
close #334
Todo
Checklist
npm testruns for the whole project.