Added a new template based notification hook (e.g for Slack)#338
Merged
J12934 merged 133 commits intosecureCodeBox:mainfrom Apr 19, 2021
Merged
Added a new template based notification hook (e.g for Slack)#338J12934 merged 133 commits intosecureCodeBox:mainfrom
J12934 merged 133 commits intosecureCodeBox:mainfrom
Conversation
J12934
reviewed
Mar 25, 2021
nigthknight
force-pushed
the
feature/notification-hook
branch
from
51993a2 to
f44653f
Compare
rfelber
reviewed
Mar 31, 2021
rfelber
reviewed
Mar 31, 2021
nigthknight
force-pushed
the
feature/notification-hook
branch
4 times, most recently
from
fb3ddf2 to
051cfde
Compare
J12934
reviewed
Apr 7, 2021
J12934
requested changes
Apr 12, 2021
nigthknight
force-pushed
the
feature/notification-hook
branch
3 times, most recently
from
4442b0e to
d583b23
Compare
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
This Hook will be used for notifications to Slack, MS Teams, Email and others. To simplify the implementation I introduced a NotifierFactory to handle the creation of different Notifiers that handle sending and default templating. Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
nigthknight
force-pushed
the
feature/notification-hook
branch
from
d583b23 to
2a4a2f6
Compare
We decided it would be best if we provide the additional args to the Notifiers via process.env to enable us to protect some of these args as secrets Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
nigthknight
force-pushed
the
feature/notification-hook
branch
from
2a4a2f6 to
7b103e0
Compare
We decided that we want to protect the `endPoint` for a NotificationChannel using secrets to avoid leaking e.g. webhook urls Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
nigthknight
force-pushed
the
feature/notification-hook
branch
from
67e5294 to
22b0a11
Compare
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
…ecureCodeBox into feature/notification-hook
I changed the NOTES.txt to display some basic information about deployed notifications Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
J12934
approved these changes
Apr 19, 2021
rfelber
changed the title
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If applied this PR will add a generic notification-hook.
The notification-hook is supposed to combine slack, ms-teams, email etc.
The ms-teams-webhook will be replaced by this hook in a future release.
This PR does only support Slack Notifications.
Other Notifiers will be added in another PR.
Closes #310
See #318