fix(minio): Fixed port forward script to fit change to bitnami minio charts#1401
Merged
Weltraumschaf merged 1 commit intomainfrom Oct 12, 2022
Merged
fix(minio): Fixed port forward script to fit change to bitnami minio charts#1401Weltraumschaf merged 1 commit intomainfrom
Weltraumschaf merged 1 commit intomainfrom
Conversation
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
Weltraumschaf
requested changes
Oct 12, 2022
Member
Weltraumschaf
left a comment
Weltraumschaf
left a comment
There was a problem hiding this comment.
LGTM
But you should describe in the commit message why you did this:
- Why is the port changed? did qe changed something or did Minio changed something?
- Why is accesskey renamed to root-user?
You can do this with amend commit && force push
…charts in #1340 In #1340 we changed from using official minio helm charts to the bitnami minio charts. This is done because we deemed them more stable and mature As a result the secrets json file has a different schema: .data.accesskey --> .data.root-user .data.secretkey --> .data.root-password The exposed ports are also now divided into API:9000 and Console:9001 src: https://artifacthub.io/packages/helm/bitnami/minio Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala
force-pushed
the
fix/minio-port-foward-script
branch
from
ce8c631 to
15570d8
Compare
Weltraumschaf
approved these changes
Oct 12, 2022
Ilyesbdlala
added a commit
to secureCodeBox/documentation
that referenced
this pull request
Oct 12, 2022
Related to secureCodeBox/secureCodeBox#1401 Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed port forward script to fit change to bitnami minio charts in #1340.
In #1340 we changed from using official minio helm charts to the bitnami minio charts.
This is done because we deemed them more stable and mature
As a result the secrets json file has a different schema:
The exposed ports are also now divided into API:9000 and Console:9001
src: https://artifacthub.io/packages/helm/bitnami/minio
Signed-off-by: Ilyes Ben Dlala ilyes.bendlala@iteratec.com
Description
Checklist