Skip to content
This repository was archived by the owner on Feb 26, 2021. It is now read-only.

nmap security headers#59

Merged
bitofant merged 8 commits intodevelopfrom
feature/nmap-security-headers
Jan 25, 2019
Merged

nmap security headers#59
bitofant merged 8 commits intodevelopfrom
feature/nmap-security-headers

Conversation

@bitofant
Copy link
Contributor

Added option to check http header configuration to combined amass/nmap scan. Depends on my pull request on nmap scanner (non-breaking; software will run without nmap update but this feature will not be testable).

# Conflicts:
#	scb-scanprocesses/combined-amass-nmap-process/src/main/java/io/securecodebox/scanprocesses/amassnmap/TransformAmassResultsToNmapInput.java
#	scb-scanprocesses/combined-amass-nmap-process/src/main/resources/bpmn/combined_amass_nmap_process.bpmn
@MartinLang1 MartinLang1 changed the base branch from master to develop January 24, 2019 09:29
Copy link
Contributor

@MartinLang1 MartinLang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • i changed the target branch to develop (was master before)
  • there are merge conflicts & build is failing
  • some minor changes (see comments for more details)
  • but overall i like your approach 👍
  • very elegant solution using the HttpStrategies

@bitofant bitofant merged commit 23d79da into develop Jan 25, 2019
@J12934 J12934 deleted the feature/nmap-security-headers branch February 13, 2019 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants