Skip to content

issue #504#505

Closed
rsoika wants to merge 4 commits intoscribejava:masterfrom
rsoika:master
Closed

issue #504#505
rsoika wants to merge 4 commits intoscribejava:masterfrom
rsoika:master

Conversation

@rsoika
Copy link

@rsoika rsoika commented Aug 12, 2014

these are my changes discussed in

#504

@fernandezpablo85
Copy link
Collaborator

I see that only getRequestToken has the RequestTuner overload... I'd rather have it on every interface call or leave it as it is (nowhere)

@rsoika
Copy link
Author

rsoika commented Aug 13, 2014

I added

 public Token getAccessToken(Token requestToken, Verifier verifier,RequestTuner tuner);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't include this file in the PR

@johnhiott
Copy link

@fernandezpablo85 if this were cleaner, would you merge it in?

@fernandezpablo85
Copy link
Collaborator

@kullfar, WDYT?

@kullfar
Copy link
Member

kullfar commented Jan 11, 2016

Hi, @johnhiott!
Seems like this Pull Request is out-of-dated. It's about RequestTuner, and there is no such class anymore. Try to rebase or completely rework this pull request.
I'll close this one. If you will have any needs to change smth in the current version of scribejava, feel free to create the new Pull Request. Thanks!

@kullfar kullfar closed this Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants