This repository was archived by the owner on Aug 11, 2023. It is now read-only.
Changes for tf2 in hydro - frame naming#167
Merged
Merged
Conversation
ghost
assigned
Contributor
Author
|
Merged the geometry2 module directly in - original causes bugs and shouldn't be used hereafter in hydro anyway and this gives a clearer diff. |
Contributor
Author
|
Don't merge this yet - it's a work in progress. |
Contributor
Author
|
Merging so I can test and move on to other pull requests. @damonkohler if you've got any requests, we can easily come back and attack this. |
stonier
added a commit
that referenced
this pull request
Aug 29, 2013
Changes for tf2 in hydro - frame naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://www.ros.org/wiki/hydro/Migration#tf2.2BAC8-Migration.Removal_of_support_for_tf_prefix
They are no longer attempting to handle graph names. As it turns out, with some packages having updated and others none, rosjava causes havoc with the names. This is the case for android_tutorial_map_view where lookups to common roots fail (map-base_link) because its trying to compare the graph name resolved
/mapwith the map header stringmapthat got saved in the transform class internally.I've fleshed out some rosjava_geometry2 modules that remove usage of GraphName with FrameName. The only special feature of that class is the python/cpp implementation's stripping of any leading slashes. This resolves the problems for android_tutorial_map_viewer in hydro.