Skip to content

handle TemplateElement with null cooked value#6177

Merged
lukastaegert merged 1 commit intomasterfrom
fix/invalid-template-literal
Nov 10, 2025
Merged

handle TemplateElement with null cooked value#6177
lukastaegert merged 1 commit intomasterfrom
fix/invalid-template-literal

Conversation

@TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Nov 8, 2025 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #6175
resolves #6176

Description

@vercel
Copy link

vercel bot commented Nov 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rollup Ready Ready Preview Comment Nov 8, 2025 5:12pm

@github-actions
Copy link

github-actions bot commented Nov 8, 2025 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/invalid-template-literal

Notice: Ensure you have installed the latest nightly Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-1sxzy8447-rollup-js.vercel.app/repl/?pr=6177

@github-actions
Copy link

github-actions bot commented Nov 8, 2025 •
edited
Loading

Performance report

  • BUILD: 7097ms, 816 MB (-2%)
    • initialize: 0ms, 24.6 MB (+7%)
    • generate module graph: 2670ms, 631 MB
      • generate ast: 1391ms, 621 MB
    • sort and bind modules: 408ms, 688 MB
    • mark included statements: 4008ms, 816 MB (-2%)
      • treeshaking pass 1: 2357ms, 813 MB
      • treeshaking pass 2: 466ms, 835 MB (-3%)
      • treeshaking pass 3: 400ms, 818 MB (-2%)
      • treeshaking pass 4: 388ms, 811 MB
      • treeshaking pass 5: 386ms, 816 MB (-2%)
  • GENERATE: 704ms (+21ms, +3.0%), 903 MB
    • initialize render: 0ms, 816 MB (-2%)
    • generate chunks: 49ms, 838 MB
      • optimize chunks: 0ms, 835 MB (-2%)
    • render chunks: 632ms (+14ms, +2.2%), 890 MB
    • transform chunks: 20ms, 903 MB
    • generate bundle: 0ms, 903 MB

@TrickyPi TrickyPi force-pushed the fix/invalid-template-literal branch from 21d9705 to 4c521c3 Compare November 8, 2025 16:45
@codecov
Copy link

codecov bot commented Nov 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (e3bdcdf) to head (bc328b1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6177      +/-   ##
==========================================
+ Coverage   98.72%   98.74%   +0.01%     
==========================================
  Files         271      271              
  Lines       10639    10639              
  Branches     2847     2847              
==========================================
+ Hits        10503    10505       +2     
  Misses         91       91              
+ Partials       45       43       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TrickyPi TrickyPi force-pushed the fix/invalid-template-literal branch from 4c521c3 to bc328b1 Compare November 8, 2025 17:11
lukastaegert
lukastaegert approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, thanks for the quick fix!

@lukastaegert lukastaegert added this pull request to the merge queue Nov 10, 2025
Merged via the queue into master with commit 4f43f03 Nov 10, 2025
83 of 84 checks passed
@lukastaegert lukastaegert deleted the fix/invalid-template-literal branch November 10, 2025 05:14
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

This PR has been released as part of rollup@4.53.2. You can test it via npm install rollup.

This was referenced Nov 10, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RollupError: called Option::unwrap() on a None value with Rollup >=4.53 important problem !!! String.raw trans error!!!

2 participants

@TrickyPi @lukastaegert