Skip to content

Add test-install CI job to test packaging, installation and importing of rollup package#6171

Merged
lukastaegert merged 4 commits intorollup:masterfrom
antoninkriz:test-install
Nov 16, 2025
Merged

Add test-install CI job to test packaging, installation and importing of rollup package#6171
lukastaegert merged 4 commits intorollup:masterfrom
antoninkriz:test-install

Conversation

@antoninkriz
Copy link
Contributor

@antoninkriz antoninkriz commented Nov 7, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This PR adds CI job to test packaging, installation and import of rollup package. This check should warn against future occurrences of issues similar to #6168.

Very hacky pipeline runs which shows:

@vercel
Copy link

vercel bot commented Nov 7, 2025

@antoninkriz is attempting to deploy a commit to the rollup-js Team on Vercel.

A member of the Team first needs to authorize it.

@antoninkriz antoninkriz marked this pull request as ready for review November 7, 2025 19:49
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that is actually a nice idea! Will think a little about this before merging as it is late today already at my place. Hope the fix goes through well.

@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rollup Ready Ready Preview Comment Nov 16, 2025 10:41am

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (18ee41b) to head (2906766).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6171   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         271      271           
  Lines       10639    10639           
  Branches     2847     2847           
=======================================
  Hits        10505    10505           
  Misses         91       91           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again and sorry for the wait. I took the liberty to inline the install test into the regular test runs as that saves us some runners and there is a lot of overhead just to get to that point. If that works, I will merge it.

@lukastaegert lukastaegert added this pull request to the merge queue Nov 15, 2025
@lukastaegert lukastaegert removed this pull request from the merge queue due to a manual request Nov 15, 2025
@lukastaegert lukastaegert added this pull request to the merge queue Nov 16, 2025
Merged via the queue into rollup:master with commit 4b4581d Nov 16, 2025
44 checks passed
@github-actions
Copy link

This PR has been released as part of rollup@4.53.3. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants