fix: generation of debugIDs with invalid length#6144
Merged
lukastaegert merged 5 commits intorollup:masterfrom Oct 18, 2025
Merged
fix: generation of debugIDs with invalid length#6144lukastaegert merged 5 commits intorollup:masterfrom
lukastaegert merged 5 commits intorollup:masterfrom
Conversation
|
@pablomatiasgomez is attempting to deploy a commit to the rollup-js Team on Vercel. A member of the Team first needs to authorize it. |
pablomatiasgomez
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
lukastaegert
approved these changes
Oct 18, 2025
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
I see what you mean, nice work!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6144 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 271 271
Lines 10638 10638
Branches 2847 2847
=======================================
Hits 10502 10502
Misses 91 91
Partials 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR has been released as part of rollup@4.52.5. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
debugIDs are meant to be valid UUIDs (as stated in http://github.com/tc39/ecma426/blob/main/proposals/debug-id.md) but the current approach is, in some cases, producing invalid UUIDs that basically have a missing character. This happens because this was using a to_string function that first converts the hash to a int, and in cases with a leading zero, the conversion to hex chars will miss the leading zero (only happens for the first byte, leading zeros in subsequent bytes are handled correctly).
This change should only affect debugIDs that were invalid, other cases should still provide the same results. I changed one test that validates this:
The generated debugIDs were/are: