Skip to content

fix(rust): use prebuilt std when it is available#6109

Merged
lukastaegert merged 11 commits intorollup:masterfrom
cyyynthia:patch-1
Sep 23, 2025
Merged

fix(rust): use prebuilt std when it is available#6109
lukastaegert merged 11 commits intorollup:masterfrom
cyyynthia:patch-1

Conversation

@cyyynthia
Copy link
Contributor

@cyyynthia cyyynthia commented Sep 16, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This change links LLVM's compiler-rt which should hopefully bring in the missing symbols for all platforms.

@vercel
Copy link

vercel bot commented Sep 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rollup Ready Ready Preview Comment Sep 17, 2025 11:53am

@cyyynthia cyyynthia changed the title fix(rust): enable compiler-builtins-c for build-std in napi build fix(rust): use prebuilt std when it is available Sep 16, 2025
@robertkirkman
Copy link

robertkirkman commented Sep 17, 2025

When it passes, i would like to know if it is possible for me to test this PR on my device in some way, please let me know

@codecov
Copy link

codecov bot commented Sep 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (7471074) to head (50e97f9).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6109   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         271      271           
  Lines       10641    10641           
  Branches     2848     2848           
=======================================
  Hits        10507    10507           
  Misses         89       89           
  Partials       45       45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lukastaegert
lukastaegert reviewed Sep 19, 2025
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I will trigger a beta build to try this out from the branch and get feedback.

BTW looking at this issue we just received for OHOS which has the same issue in a different context #6115, another solution might be to also exclude android here. Let's see what works.

@lukastaegert
Copy link
Member

lukastaegert commented Sep 19, 2025

Released as rollup@4.50.3-0

@lukastaegert lukastaegert added this pull request to the merge queue Sep 23, 2025
Merged via the queue into rollup:master with commit 10b2672 Sep 23, 2025
44 checks passed
@cyyynthia cyyynthia deleted the patch-1 branch September 23, 2025 07:45
@github-actions
Copy link

github-actions bot commented Sep 23, 2025

This PR has been released as part of rollup@4.52.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyyynthia @robertkirkman @lukastaegert