Skip to content

feat: support ROLLUP_FILE_URL_OBJ for URL object instead of string#6108

Merged
lukastaegert merged 2 commits intomasterfrom
file-url-obj
Sep 17, 2025
Merged

feat: support ROLLUP_FILE_URL_OBJ for URL object instead of string#6108
lukastaegert merged 2 commits intomasterfrom
file-url-obj

Conversation

@guybedford
Copy link
Contributor

@guybedford guybedford commented Sep 14, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Adds support for import.meta.ROLLUP_FILE_URL_OBJ_referenceId as discussed.

@vercel
Copy link

vercel bot commented Sep 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rollup Ready Ready Preview Comment Sep 16, 2025 4:54am

@github-actions
Copy link

github-actions bot commented Sep 14, 2025

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#file-url-obj

Notice: Ensure you have installed the latest nightly Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-cqkxypwpo-rollup-js.vercel.app/repl/?pr=6108

@guybedford guybedford changed the title feat: support ROLLUP_FILE_URL_OBJ asset references for URL object ins… feat: support ROLLUP_FILE_URL_OBJ for URL object instead of string Sep 14, 2025
@github-actions
Copy link

github-actions bot commented Sep 14, 2025

Performance report

  • BUILD: 6916ms, 826 MB
    • initialize: 0ms, 25 MB
    • generate module graph: 2574ms, 635 MB
      • generate ast: 1359ms (-30ms, -2.2%), 624 MB
    • sort and bind modules: 390ms, 695 MB (+3%)
    • mark included statements: 3939ms (-95ms, -2.3%), 826 MB
      • treeshaking pass 1: 2320ms (-49ms, -2.0%), 823 MB
      • treeshaking pass 2: 459ms, 826 MB
      • treeshaking pass 3: 390ms, 827 MB (+3%)
      • treeshaking pass 4: 381ms, 811 MB
      • treeshaking pass 5: 374ms, 826 MB
  • GENERATE: 730ms (-157ms, -17.7%), 931 MB
    • initialize render: 0ms, 904 MB (-3%)
    • generate chunks: 151ms (+90ms, +148.9%), 897 MB (-5%)
      • optimize chunks: 0ms, 884 MB (-6%)
    • render chunks: 640ms, 913 MB
    • transform chunks: 19ms, 931 MB
    • generate bundle: 0ms, 931 MB

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (76a3b8e) to head (855bfb5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6108   +/-   ##
=======================================
  Coverage   98.73%   98.74%           
=======================================
  Files         271      271           
  Lines       10632    10641    +9     
  Branches     2843     2848    +5     
=======================================
+ Hits        10498    10507    +9     
  Misses         89       89           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukastaegert lukastaegert added this pull request to the merge queue Sep 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 16, 2025
@lukastaegert lukastaegert added this pull request to the merge queue Sep 17, 2025
Merged via the queue into master with commit 7471074 Sep 17, 2025
45 checks passed
@lukastaegert lukastaegert deleted the file-url-obj branch September 17, 2025 07:02
@github-actions
Copy link

This PR has been released as part of rollup@4.50.3-0. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@4.50.3-0 or npm install rollup@beta. It will likely become part of a regular release later.

@github-actions
Copy link

This PR has been released as part of rollup@4.51.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants