Fix illegal instruction error on arm64 by enabling no_opt_arch feature for mimalloc-safe#6055
Merged
lukastaegert merged 1 commit intorollup:masterfrom Aug 18, 2025
Conversation
…ure for mimalloc-safe
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6055 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 271 271
Lines 10601 10601
Branches 2830 2830
=======================================
Hits 10473 10473
Misses 88 88
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks! Unfortunately I do not have access to my computer for the next two weeks. If you want an earlier release, we will need to see if I can give @TrickyPi publishing rights. |
Contributor
Author
|
That would be great 🙏 |
3 tasks
|
This PR has been released as part of rollup@4.46.3. You can test it via |
This was referenced Aug 18, 2025
cyyynthia
added a commit
to cyyynthia/rollup
that referenced
this pull request
Aug 18, 2025
initially introduced by rollup#6055 for linux, this did not include android devices as it is considerd its own operating system with linux being the "vendor"; triplets are quite inconsistent and confusing at times! this change conservatively disables arch-specific optimizations for all aarch64 targets, to ensure broad compatibility. closes rollup#6047
10 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2025
* build(rust): mimalloc-safe/no_opt_arch on aarch64 initially introduced by #6055 for linux, this did not include android devices as it is considerd its own operating system with linux being the "vendor"; triplets are quite inconsistent and confusing at times! this change conservatively disables arch-specific optimizations for all aarch64 targets, to ensure broad compatibility. closes #6047 * build(rust): exclude Apple from arch-specific opt-out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
I don't have a aarch64 device so I cannot verify if this fix works. I found this fix in oxc-project/oxc#11045.
The cause is probably the same https://github.com/rollup/rollup/pull/6027/files#diff-232adeab3538fc2304f20f64aee234e2b54a5b830b5de1464ab403fb5e095228L13-R22, #6047 (comment).