feat: upgrade to NAPI-RS 3 stable#6027
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6027 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 270 270
Lines 10583 10583
Branches 2823 2823
=======================================
Hits 10456 10456
Misses 87 87
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Nice, and the workflow improvements are really cool. There is just one job that stands out: The riscv64gc-unknown-linux-gnu build now takes over 20 minutes as opposed to less than 3 minutes it took before. Nearly all of this goes apparently to the installation of the additional dependency. If this is really needed, I wonder if we can switch to a pre-built docker image to handle this? Do you have any insights?
|
@lukastaegert I believe this is just a network flaky with GitHub Actions, it's only take 
Can you retry the build and let's see if the slow CI issue still occurs? |
|
The rerun time appears to be reasonable 
|
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
# Conflicts: # package-lock.json # package.json
|
This PR has been released as part of rollup@4.45.3. You can test it via |
3 participants
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Upgrade to NAPI-RS 3.0, see https://napi.rs/blog/announce-v3 for more details