Skip to content

Support @__PURE__ when nested after new in constructor invocations#5998

Merged
lukastaegert merged 1 commit intomasterfrom
fix/5995
Jul 4, 2025
Merged

Support @__PURE__ when nested after new in constructor invocations#5998
lukastaegert merged 1 commit intomasterfrom
fix/5995

Conversation

@TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5995

Description

@vercel
Copy link

vercel bot commented Jun 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2025 0:13am

@github-actions
Copy link

github-actions bot commented Jun 29, 2025

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5995

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-j226j0rfb-rollup-js.vercel.app/repl/?pr=5998

@github-actions
Copy link

Performance report

  • BUILD: 6970ms, 818 MB
    • initialize: 0ms, 24.7 MB
    • generate module graph: 2604ms, 629 MB
      • generate ast: 1388ms, 619 MB
    • sort and bind modules: 389ms, 684 MB
    • mark included statements: 3958ms, 818 MB
      • treeshaking pass 1: 2304ms, 819 MB
      • treeshaking pass 2: 462ms, 837 MB
      • treeshaking pass 3: 396ms, 823 MB
      • treeshaking pass 4: 383ms, 842 MB
      • treeshaking pass 5: 383ms, 818 MB
  • GENERATE: 879ms (+65ms, +8.0%), 924 MB
    • initialize render: 0ms, 932 MB (+16%)
    • generate chunks: 257ms (+117ms, +83.6%), 886 MB (+6%)
      • optimize chunks: 0ms, 909 MB (+10%)
    • render chunks: 651ms (+42ms, +6.9%), 898 MB
    • transform chunks: 19ms, 924 MB
    • generate bundle: 0ms, 924 MB

@codecov
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (5a7f9e2) to head (8d05026).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5998   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files         270      270           
  Lines        8745     8745           
  Branches     1512     1512           
=======================================
  Hits         8639     8639           
  Misses         73       73           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@lukastaegert lukastaegert added this pull request to the merge queue Jul 4, 2025
Merged via the queue into master with commit a916563 Jul 4, 2025
42 checks passed
@lukastaegert lukastaegert deleted the fix/5995 branch July 4, 2025 06:03
@github-actions
Copy link

github-actions bot commented Jul 4, 2025

This PR has been released as part of rollup@4.44.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@__PURE__ are not supported when nested after the new in a constructor invocation

2 participants