fix(assetFileNames): reduce max hash size to 21#5921
Merged
lukastaegert merged 1 commit intorollup:masterfrom Apr 26, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5921 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 270 270
Lines 8692 8692
Branches 1488 1489 +1
=======================================
Hits 8566 8566
Misses 93 93
Partials 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukastaegert
approved these changes
Apr 26, 2025
Member
|
In the future, we might consider to warn about this, but for now I think it is fine. |
|
This PR has been released as part of rollup@4.40.1. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
hashforassetFileNamesshould be21#5920Description
This reduces the maximum allowed hash size from 22 to 21 as for base64, sometimes the hash size would be just 21, resulting in unexpected files names and off-by-one source maps.