Correct the behavior when multiple transform filter options are specified#5909
Merged
lukastaegert merged 3 commits intorollup:masterfrom Apr 12, 2025
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5909 +/- ##
==========================================
- Coverage 98.56% 98.56% -0.01%
==========================================
Files 270 270
Lines 8688 8683 -5
Branches 1488 1488
==========================================
- Hits 8563 8558 -5
Misses 92 92
Partials 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sxzz
reviewed
Apr 11, 2025
sxzz
added a commit
to unjs/unplugin
that referenced
this pull request
Apr 11, 2025
…ons are specified ref: rollup/rollup#5909
lukastaegert
approved these changes
Apr 12, 2025
|
This PR has been released as part of rollup@4.40.0. You can test it via |
MelanieClayton920KimberlyHubbard
added a commit
to MelanieClayton920KimberlyHubbard/unplugin
that referenced
this pull request
Oct 12, 2025
…ons are specified ref: rollup/rollup#5909
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
When multiple filter options were specified for a transform hook, the hook ran when either of it matched.
For example, the following filter matched for modules that whose id is
fooor whose code containsa.This is not useful.
This PR fixes that behavior. After this PR, the filter above only matches if the module id is
fooand the code containsa.The previous behavior (that is probably rarely needed) can be achieved by using multiple plugins:
refs rolldown/rolldown#4059