Skip to content

docs: add utf-8 encoding to JSON file reading#5759

Merged
lukastaegert merged 1 commit intorollup:masterfrom
chouchouji:docs-command-line-interface
Dec 13, 2024
Merged

docs: add utf-8 encoding to JSON file reading#5759
lukastaegert merged 1 commit intorollup:masterfrom
chouchouji:docs-command-line-interface

Conversation

@chouchouji
Copy link
Contributor

@chouchouji chouchouji commented Dec 9, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@vercel
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 2:47pm

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting!

@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (e60fb1c) to head (5526dab).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5759   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         258      258           
  Lines        8072     8072           
  Branches     1361     1361           
=======================================
  Hits         7992     7992           
  Misses         53       53           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert added this pull request to the merge queue Dec 13, 2024
Merged via the queue into rollup:master with commit 7a8ac46 Dec 13, 2024
@github-actions
Copy link

This PR has been released as part of rollup@4.29.0-0. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@4.29.0-0 or npm install rollup@beta. It will likely become part of a regular release later.

@github-actions
Copy link

This PR has been released as part of rollup@4.29.0-1. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@4.29.0-1 or npm install rollup@beta. It will likely become part of a regular release later.

@github-actions
Copy link

This PR has been released as part of rollup@4.29.0-2. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@4.29.0-2 or npm install rollup@beta. It will likely become part of a regular release later.

@github-actions
Copy link

This PR has been released as part of rollup@4.29.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants