feat: support using for RollupBuild#5721
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Thank you, and also for considering the docs. I have some small comments, especially since to my understanding, no runtime fully supports the feature yet.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5721 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 258 258
Lines 8069 8070 +1
Branches 1360 1360
=======================================
+ Hits 7989 7990 +1
Misses 53 53
Partials 27 27 ☔ View full report in Codecov by Sentry. |
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks, this looks good. I still think, though, that it would be nice to have at least a hint in the docs that you can do that. How about in the example, we replace the // create a bundle comment with something like
// Create a bundle. If you are using TypeScript or a runtime that
// supports it, you can write
//
// await using bundle = await rollup(inputOptions);
//
// instead and do not need to close the bundle explicitly below.
shulaoda
force-pushed
the
feat/support-using-for-rollup-build
branch
from
1fd869a to
d163eb3
Compare
|
This PR has been released as part of rollup@4.26.0. You can test it via |
2 participants
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #5714
Description
Since this is a new
TypeScriptfeature, I'm not sure how to add additional test cases on theJavaScriptside.