Update configuration-options document#5708
Merged
lukastaegert merged 3 commits intorollup:masterfrom Nov 4, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
use the correct new terminology Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>
lukastaegert
approved these changes
Oct 30, 2024
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks for taking the time to improve the docs ❤️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5708 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 257 257
Lines 8055 8055
Branches 1358 1358
=======================================
Hits 7976 7976
Misses 52 52
Partials 27 27 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of rollup@4.24.4. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nodejs.org/docs/latest-v22.x/api/esm.html#import-attributes https://stackoverflow.com/a/78876692/12639496
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
assert { type: 'json' }replaced to
with { type: 'json' }in node v18.20.0
node v22 is LTS.
node@22 not working with
assert { type: 'json' }https://nodejs.org/docs/latest-v22.x/api/esm.html#import-attributes
https://stackoverflow.com/questions/78876691/syntaxerror-unexpected-identifier-assert-on-json-import-in-node-v22