Skip to content

fix: Wrong namespace property definition#5605

Merged
lukastaegert merged 2 commits intorollup:masterfrom
thirumurugan-git:fix-wrong-namespace-property-definition
Aug 30, 2024
Merged

fix: Wrong namespace property definition#5605
lukastaegert merged 2 commits intorollup:masterfrom
thirumurugan-git:fix-wrong-namespace-property-definition

Conversation

@thirumurugan-git
Copy link
Contributor

@thirumurugan-git thirumurugan-git commented Aug 5, 2024 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@vercel
Copy link

vercel bot commented Aug 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 4:56am

@thirumurugan-git thirumurugan-git mentioned this pull request Aug 5, 2024
Closed
@thirumurugan-git
Copy link
Contributor Author

thirumurugan-git commented Aug 6, 2024

@lukastaegert / @TrickyPi Could you review this pull request?

@TrickyPi
Copy link
Member

TrickyPi commented Aug 6, 2024

Thanks for your contribution, It would be great if you can add specific tests for this fix!

@thirumurugan-git thirumurugan-git force-pushed the fix-wrong-namespace-property-definition branch from 8069ff3 to 38e2e61 Compare August 25, 2024 18:47
@thirumurugan-git
Copy link
Contributor Author

thirumurugan-git commented Aug 25, 2024

@TrickyPi / @lukastaegert I've added the test for the fix. Please review.

@codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.04%. Comparing base (16fe124) to head (741ad1b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/finalisers/shared/setupNamespace.ts 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5605   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files         242      242           
  Lines        9329     9339   +10     
  Branches     2467     2469    +2     
=======================================
+ Hits         9240     9250   +10     
  Misses         58       58           
  Partials       31       31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert
Copy link
Member

lukastaegert commented Aug 26, 2024

Looks good to me, but you will need to run npm run lint once locally and commit the fixes 😉. Thanks for adding the tests!

@thirumurugan-git thirumurugan-git force-pushed the fix-wrong-namespace-property-definition branch from 38e2e61 to 3eb0fee Compare August 27, 2024 15:15
@thirumurugan-git
Copy link
Contributor Author

thirumurugan-git commented Aug 27, 2024

@lukastaegert done! 😉

@thirumurugan-git
Copy link
Contributor Author

thirumurugan-git commented Aug 28, 2024

@lukastaegert Can you approve the workflow?

@lukastaegert lukastaegert enabled auto-merge August 30, 2024 04:54
@lukastaegert lukastaegert disabled auto-merge August 30, 2024 06:51
@lukastaegert lukastaegert merged commit 608a8f0 into rollup:master Aug 30, 2024
@github-actions
Copy link

github-actions bot commented Aug 30, 2024

This PR has been released as part of rollup@4.21.2. You can test it via npm install rollup.

@YashGovekar YashGovekar mentioned this pull request Sep 20, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Sep 20, 2024
Open
This was referenced Sep 21, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 22, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Sep 23, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Sep 23, 2024
Open
This was referenced Sep 23, 2024
Open
Open
This was referenced Sep 25, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 2, 2024
Open
Open
This was referenced Oct 4, 2024
Open
Open
@YashGovekar YashGovekar mentioned this pull request Oct 4, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Oct 4, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Oct 5, 2024
Open
This was referenced Oct 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong namespace property definition when namespaced output.name with first-level reserved key.

3 participants

@thirumurugan-git @TrickyPi @lukastaegert