Skip to content

fix: function parameter reassigned update#5482

Merged
lukastaegert merged 1 commit intorollup:masterfrom
liuly0322:dev
Apr 22, 2024
Merged

fix: function parameter reassigned update#5482
lukastaegert merged 1 commit intorollup:masterfrom
liuly0322:dev

Conversation

@liuly0322
Copy link
Contributor

@liuly0322 liuly0322 commented Apr 22, 2024 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

REPL

markReassigned caused by reassignment in ParameterVariable should not be shadowed by UnknownKey.

Also I am checking other issues related to 4.16.1.

Currently known other issues:

@vercel
Copy link

vercel bot commented Apr 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 8:49am

@liuly0322 liuly0322 changed the title fix: reassigned (and maybe more treeshake parameter error here...) fix: function parameter reassigned update Apr 22, 2024
@liuly0322 liuly0322 mentioned this pull request Apr 22, 2024
Merged
9 tasks
@brophdawg11 brophdawg11 mentioned this pull request Apr 22, 2024
Closed
@github-actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install liuly0322/_rollup#dev

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-5tn789hw8-rollup-js.vercel.app/repl/?pr=5482

lukastaegert
lukastaegert approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@lukastaegert lukastaegert merged commit 4bbe1a3 into rollup:master Apr 22, 2024
@github-actions
Copy link

github-actions bot commented Apr 22, 2024

This PR has been released as part of rollup@4.16.2. You can test it via npm install rollup.

@sapphi-red sapphi-red mentioned this pull request Apr 22, 2024
Closed
7 tasks
@liuly0322 liuly0322 deleted the dev branch April 28, 2024 04:19
@leonardoadame leonardoadame mentioned this pull request May 19, 2024
Open
@YashGovekar YashGovekar mentioned this pull request May 19, 2024
Open
@x-way x-way mentioned this pull request May 20, 2024
Closed
@leonardoadame leonardoadame mentioned this pull request May 20, 2024
Open
This was referenced May 21, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request May 22, 2024
Open
This was referenced May 23, 2024
Open
Open
Open
Open
Open
Open
Open
@YashGovekar YashGovekar mentioned this pull request May 30, 2024
Open
@x-way x-way mentioned this pull request May 31, 2024
Closed
@YashGovekar YashGovekar mentioned this pull request Jun 1, 2024
Open
@hashim21223445 hashim21223445 mentioned this pull request Jul 29, 2024
Merged
@YashGovekar YashGovekar mentioned this pull request Jul 29, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Jul 29, 2024
Open
This was referenced Jul 30, 2024
Open
Open
@x-way x-way mentioned this pull request Jul 31, 2024
Closed
This was referenced Aug 2, 2024
Open
Open
Open
Open
Open
Open
Open
@hashim21223445 hashim21223445 mentioned this pull request Aug 9, 2024
Merged
This was referenced Aug 9, 2024
Open
Open
@x-way x-way mentioned this pull request Aug 10, 2024
Closed
@leonardoadame leonardoadame mentioned this pull request Aug 10, 2024
Open
@hashim21223445 hashim21223445 mentioned this pull request Aug 10, 2024
Merged
This was referenced Aug 11, 2024
Open
Open
Open
Open
Open
@x-way x-way mentioned this pull request Aug 18, 2024
Closed
@leonardoadame leonardoadame mentioned this pull request Aug 19, 2024
Open
This was referenced Aug 19, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

x⁸ ⚙️ build repl artefacts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liuly0322 @lukastaegert