Skip to content

Add libc field to armv7 packages#5479

Merged
lukastaegert merged 1 commit intorollup:masterfrom
sapphi-red:fix/add-libc-armv7
Apr 22, 2024
Merged

Add libc field to armv7 packages#5479
lukastaegert merged 1 commit intorollup:masterfrom
sapphi-red:fix/add-libc-armv7

Conversation

@sapphi-red
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Without libc field, both packages will be downloaded by the package manager.

@vercel
Copy link

vercel bot commented Apr 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2024 10:37am

@codecov
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (38fe707) to head (f23d90c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5479   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         238      238           
  Lines        9554     9554           
  Branches     2439     2439           
=======================================
  Hits         9443     9443           
  Misses         46       46           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed that. Thanks for spotting!

@lukastaegert lukastaegert added this pull request to the merge queue Apr 22, 2024
@lukastaegert lukastaegert removed this pull request from the merge queue due to a manual request Apr 22, 2024
@lukastaegert lukastaegert merged commit a80117f into rollup:master Apr 22, 2024
@sapphi-red sapphi-red deleted the fix/add-libc-armv7 branch April 22, 2024 05:50
@github-actions
Copy link

This PR has been released as part of rollup@4.16.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants