Skip to content

Ensure reexported namespaces do not prevent creation of default export helpers#5466

Merged
lukastaegert merged 4 commits intomasterfrom
gh-5465
Apr 12, 2024
Merged

Ensure reexported namespaces do not prevent creation of default export helpers#5466
lukastaegert merged 4 commits intomasterfrom
gh-5465

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Apr 11, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

The problem here was an asymmetry between the logic deciding if the external namespace needed to be deconflicted locally in

rollup/src/Chunk.ts

Lines 911 to 916 in eebf061

variable.name === '*' &&
namespaceInteropHelpersByInteropType[interop(module.id)]
) {
deconflictedNamespace.add(chunk);
}
}
and the logic deciding whether to render the helper in

rollup/src/finalisers/shared/getInteropBlock.ts

Line 78 in eebf061

} else if (imported === '*' && reexported !== '*' && !hasNamespace) {
. The latter logic only rendered the namespace helper if the namespace was actually rendered, i.e. it is not just reexported as individual exports. The former, on the other hand, just looked if we imported or reexported a namespace, independent of usage. This is fixed here.

@vercel
Copy link

vercel bot commented Apr 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 5:17am

@lukastaegert lukastaegert mentioned this pull request Apr 11, 2024
Closed
@github-actions
Copy link

github-actions bot commented Apr 11, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-5465

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-r1ab2ob7b-rollup-js.vercel.app/repl/?pr=5466

@codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (2fdfe1c) to head (83ca934).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5466      +/-   ##
==========================================
+ Coverage   98.79%   98.81%   +0.02%     
==========================================
  Files         238      238              
  Lines        9449     9450       +1     
  Branches     2407     2407              
==========================================
+ Hits         9335     9338       +3     
+ Misses         48       47       -1     
+ Partials       66       65       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit cfbaaaa into master Apr 12, 2024
@lukastaegert lukastaegert deleted the gh-5465 branch April 12, 2024 06:10
@github-actions
Copy link

github-actions bot commented Apr 12, 2024

This PR has been released as part of rollup@4.14.2. You can test it via npm install rollup.

@leonardoadame leonardoadame mentioned this pull request May 19, 2024
Open
@YashGovekar YashGovekar mentioned this pull request May 19, 2024
Open
@x-way x-way mentioned this pull request May 20, 2024
Closed
@leonardoadame leonardoadame mentioned this pull request May 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CJS output contains a reference to non-existent variable when exporting default and reexporting everything with interop: compat/auto

1 participant

@lukastaegert