Skip to content

Improve error message when running on unsupported MUSL Linux#5454

Merged
lukastaegert merged 1 commit intomasterfrom
improve-no-musl-error
Apr 7, 2024
Merged

Improve error message when running on unsupported MUSL Linux#5454
lukastaegert merged 1 commit intomasterfrom
improve-no-musl-error

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Apr 5, 2024 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

When a user is running an unsupported MUSL Linux machine, the error message can be misleading as it states that the platform is unsupported while only the MUSL flavor may be unsupported.
This improves the error message by adding (musl) next to the platform in those situations in the error message, so that it matches the format of supported architectures in the list below, e.g.

Error: Your current platform "linux (musl)" and architecture "arm" combination is not yet supported by the native Rollup build. Please use the WASM build "@rollup/wasm-node" instead.

The following platform-architecture combinations are supported:
android-arm
android-arm64
darwin-arm64
darwin-x64
linux-arm
linux-arm64
linux-arm64 (musl)
linux-ppc64le
linux-riscv64
linux-s390x
linux-x64
linux-x64 (musl)
win32-arm64
win32-ia32
win32-x64

@vercel
Copy link

vercel bot commented Apr 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 1:11pm

@github-actions
Copy link

github-actions bot commented Apr 5, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#improve-no-musl-error

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-m8916ae2e-rollup-js.vercel.app/repl/?pr=5454

@codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 98.79%. Comparing base (1b85663) to head (95da7f2).

Files Patch % Lines
native.js 40.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5454      +/-   ##
==========================================
- Coverage   98.79%   98.79%   -0.01%     
==========================================
  Files         238      238              
  Lines        9446     9445       -1     
  Branches     2403     2403              
==========================================
- Hits         9332     9331       -1     
  Misses         48       48              
  Partials       66       66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert force-pushed the improve-no-musl-error branch from 159ff97 to 95da7f2 Compare April 5, 2024 13:10
@lukastaegert lukastaegert merged commit 555982a into master Apr 7, 2024
@lukastaegert lukastaegert deleted the improve-no-musl-error branch April 7, 2024 07:22
@github-actions
Copy link

github-actions bot commented Apr 7, 2024

This PR has been released as part of rollup@4.14.1. You can test it via npm install rollup.

@leonardoadame leonardoadame mentioned this pull request May 19, 2024
Open
@YashGovekar YashGovekar mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lukastaegert