chore: generate string constants from config#5451
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#feat/xiaopi-20240404Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5451 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 237 238 +1
Lines 9445 9446 +1
Branches 2403 2403
=======================================
+ Hits 9331 9332 +1
Misses 48 48
Partials 66 66 ☔ View full report in Codecov by Sentry. |
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Nice, yes, this was really something we needed!
|
This PR has been released as part of rollup@4.14.1. You can test it via |
2 participants
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Previously, to retrieve a string constant from the Rust parser, we had to modify two files. Now, only one place needs to be modified, and changing the order of string constants is also convenient.