Add locations to logs, warnings and error messages#5424
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#add-log-locationsNotice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
lukastaegert
force-pushed
the
add-log-locations
branch
from
1bf4a6e to
9be72ed
Compare
lukastaegert
force-pushed
the
add-log-locations
branch
from
9be72ed to
9580f34
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5424 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 236 236
Lines 9418 9423 +5
Branches 2396 2398 +2
=======================================
+ Hits 9305 9310 +5
Misses 48 48
Partials 65 65 ☔ View full report in Codecov by Sentry. |
lukastaegert
force-pushed
the
add-log-locations
branch
from
9580f34 to
2f72540
Compare
lukastaegert
force-pushed
the
add-log-locations
branch
from
2f72540 to
7bd1106
Compare
lukastaegert
force-pushed
the
add-log-locations
branch
from
7bd1106 to
491e861
Compare
lukastaegert
force-pushed
the
add-log-locations
branch
from
491e861 to
53d5b1c
Compare
|
This PR has been released as part of rollup@4.13.0. You can test it via |
See rollup/rollup#5424 test(typescript): update test to not have declare type
1 participant
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
RollupError: Unexpected characteroccurs #5246Description
As we keep getting issues that Rollup does not tell you the location of warnings and errors when run through tools like Vite, this PR will automatically extend all error, warning and log messages that have a location and/or a plugin to also mention this in their error message, e.g.
instead of just