fix: escape ids in import.meta.ROLLUP_FILE_URL_referenceId correctly#5404
Merged
lukastaegert merged 1 commit intorollup:masterfrom Mar 5, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5404 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 236 236
Lines 9418 9418
Branches 2396 2396
=======================================
Hits 9305 9305
Misses 48 48
Partials 65 65 ☔ View full report in Codecov by Sentry. |
lukastaegert
approved these changes
Mar 5, 2024
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Looks good to me, thanks a lot!
|
This PR has been released as part of rollup@4.12.1. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
basecauses an error vitejs/vite#13116Description
import.meta.ROLLUP_FILE_URL_referenceIdwith a file with single quote generated an invalid code. For example: