Catch Rust panics and then throw them in JS#5383
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#fix/5379Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5383 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 232 232
Lines 8997 8999 +2
Branches 2347 2348 +1
=======================================
+ Hits 8890 8892 +2
Misses 46 46
Partials 61 61 ☔ View full report in Codecov by Sentry. |
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks, that is really good to have!
At the moment, it doesn't work on WASM.
Why, what happens in WASM? Is it fixable or is it a shortcoming of the WASM target?
It seems that |
|
Amazing! Thank you so much. |
|
This PR has been released as part of rollup@4.10.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #5379
Description
At the moment, it doesn't work on WASM.