chore(deps): update dependency vite to v5.0.5 [security] by renovate[bot] · Pull Request #5285 · rollup/rollup

renovate · 2023-12-06T02:07:27Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
vite (source)	`5.0.4` -> `5.0.5`

GitHub Vulnerability Alerts

CVE-2023-49293

Summary

When Vite's HTML transformation is invoked manually via server.transformIndexHtml, the original request URL is passed in unmodified, and the html being transformed contains inline module scripts (<script type="module">...</script>), it is possible to inject arbitrary HTML into the transformed output by supplying a malicious URL query string to server.transformIndexHtml.

Impact

Only apps using appType: 'custom' and using the default Vite HTML middleware are affected. The HTML entry must also contain an inline script. The attack requires a user to click on a malicious URL while running the dev server. Restricted files aren't exposed to the attacker.

Patches

Fixed in vite@5.0.5, vite@4.5.1, vite@4.4.12

Details

Suppose index.html contains an inline module script:

<script type="module">
  // Inline script
</script>

This script is transformed into a proxy script like

<script type="module" src="/index.html?html-proxy&index=0.js"></script>

due to Vite's HTML plugin:

https://github.com/vitejs/vite/blob/7fd7c6cebfcad34ae7021ebee28f97b1f28ef3f3/packages/vite/src/node/plugins/html.ts#L429-L465

When appType: 'spa' | 'mpa', Vite serves HTML itself, and htmlFallbackMiddleware rewrites req.url to the canonical path of index.html,

https://github.com/vitejs/vite/blob/73ef074b80fa7252e0c46a37a2c94ba8cba46504/packages/vite/src/node/server/middlewares/htmlFallback.ts#L44-L47

so the url passed to server.transformIndexHtml is /index.html.

However, if appType: 'custom', HTML is served manually, and if server.transformIndexHtml is called with the unmodified request URL (as the SSR docs suggest), then the path of the transformed html-proxy script varies with the request URL. For example, a request with path / produces

<script type="module" src="/@&#8203;id/__x00__/index.html?html-proxy&index=0.js"></script>

It is possible to abuse this behavior by crafting a request URL to contain a malicious payload like

"></script><script>alert('boom')</script>

so a request to http://localhost:5173/?%22%3E%3C/script%3E%3Cscript%3Ealert(%27boom%27)%3C/script%3E produces HTML output like

<script type="module" src="/@&#8203;id/__x00__/?"></script><script>alert("boom")</script>?html-proxy&index=0.js"></script>

which demonstrates XSS.

PoC

Example 1. Serving HTML from vite dev middleware with appType: 'custom'
- Go to https://stackblitz.com/edit/vitejs-vite-9xhma4?file=main.js&terminal=dev-html
- "Open in New Tab"
- Edit URL to set query string to ?%22%3E%3C/script%3E%3Cscript%3Ealert(%27boom%27)%3C/script%3E and navigate
- Witness XSS:
Example 2. Serving HTML from SSR-style Express server (Vite dev server runs in middleware mode):
- Go to https://stackblitz.com/edit/vitejs-vite-9xhma4?file=main.js&terminal=server
- (Same steps as above)
Example 3. Plain vite dev (this shows that vanilla vite dev is not vulnerable, provided htmlFallbackMiddleware is used)
- Go to https://stackblitz.com/edit/vitejs-vite-9xhma4?file=main.js&terminal=dev
- (Same steps as above)
- You should not see the alert box in this case

Detailed Impact

This will probably predominantly affect development-mode SSR, where vite.transformHtml is called using the original req.url, per the docs:

https://github.com/vitejs/vite/blob/7fd7c6cebfcad34ae7021ebee28f97b1f28ef3f3/docs/guide/ssr.md?plain=1#L114-L126

However, since this vulnerability affects server.transformIndexHtml, the scope of impact may be higher to also include other ad-hoc calls to server.transformIndexHtml from outside of Vite's own codebase.

My best guess at bisecting which versions are vulnerable involves the following test script

import fs from 'node:fs/promises';
import * as vite from 'vite';

const html = `
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
  </head>
  <body>
    <script type="module">
      // Inline script
    </script>
  </body>
</html>
`;
const server = await vite.createServer({ appType: 'custom' });
const transformed = await server.transformIndexHtml('/?%22%3E%3C/script%3E%3Cscript%3Ealert(%27boom%27)%3C/script%3E', html);
console.log(transformed);
await server.close();

and using it I was able to narrow down to #13581. If this is correct, then vulnerable Vite versions are 4.4.0-beta.2 and higher (which includes 4.4.0).

Release Notes

vitejs/vite (vite)

`v5.0.5`

Compare Source

fix: emit vite:preloadError for chunks without deps (#15203) (d8001c5), closes #15203
fix: esbuild glob import resolve error (#15140) (676804d), closes #15140
fix: json error with position (#15225) (14be75f), closes #15225
fix: proxy html path should be encoded (#15223) (5b85040), closes #15223
fix(deps): update all non-major dependencies (#15233) (ad3adda), closes #15233
fix(hmr): don't consider CSS dep as a circular dep (#15229) (5f2cdec), closes #15229
feat: add '*.mov' to client.d.ts (#15189) (d93a211), closes #15189
feat(server): allow disabling built-in shortcuts (#15218) (7fd7c6c), closes #15218
chore: replace 'some' with 'includes' in resolveEnvPrefix (#15220) (ee12f30), closes #15220
chore: update the website url for homepage in package.json (#15181) (282bd8f), closes #15181
chore: update vitest to 1.0.0-beta.6 (#15194) (2fce647), closes #15194
refactor: make HMR agnostic to environment (#15179) (0571b7c), closes #15179
refactor: use dedicated regex methods (#15228) (0348137), closes #15228
perf: remove debug only prettifyUrl call (#15204) (73e971f), closes #15204
perf: skip computing sourceRoot in injectSourcesContent (#15207) (1df1fd1), closes #15207

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

vercel · 2023-12-06T02:07:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 6, 2023 2:08am

github-actions · 2023-12-06T02:09:45Z

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#renovate/npm-vite-vulnerability

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-k4tdld199-rollup-js.vercel.app/repl/?pr=5285

codecov · 2023-12-06T02:16:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b619fd) 98.86% compared to head (878b8c4) 98.86%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5285   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files         232      232           
  Lines        8953     8953           
  Branches     2336     2336           
=======================================
  Hits         8851     8851           
  Misses         43       43           
  Partials       59       59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-12-08T07:58:37Z

This PR has been released as part of rollup@4.7.0. You can test it via npm install rollup.

chore(deps): update dependency vite to v5.0.5 [security]

878b8c4

renovate-approve bot approved these changes Dec 6, 2023

View reviewed changes

vercel bot deployed to Preview December 6, 2023 02:08 View deployment

lukastaegert added this pull request to the merge queue Dec 6, 2023

Merged via the queue into master with commit 6267bc7 Dec 6, 2023

lukastaegert deleted the renovate/npm-vite-vulnerability branch December 6, 2023 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps): update dependency vite to v5.0.5 [security]#5285

chore(deps): update dependency vite to v5.0.5 [security]#5285
lukastaegert merged 1 commit intomasterfrom
renovate/npm-vite-vulnerability

renovate bot commented Dec 6, 2023

Uh oh!

vercel bot commented Dec 6, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Dec 6, 2023 •

edited

Loading

Uh oh!

codecov bot commented Dec 6, 2023

Uh oh!

github-actions bot commented Dec 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

renovate bot commented Dec 6, 2023

GitHub Vulnerability Alerts

CVE-2023-49293

Summary

Impact

Patches

Details

PoC

Detailed Impact

Release Notes

v5.0.5

Configuration

Uh oh!

vercel bot commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thank you for your contribution! ❤️

Uh oh!

codecov bot commented Dec 6, 2023

Codecov Report

Uh oh!

github-actions bot commented Dec 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

`v5.0.5`

vercel bot commented Dec 6, 2023 •

edited

Loading

github-actions bot commented Dec 6, 2023 •

edited

Loading