Allow this.addWatchFile in all hooks#5270
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-5260-add-watch-fileNotice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
also trigger close hook in watch mode
lukastaegert
force-pushed
the
gh-5260-add-watch-file
branch
from
9db6fd3 to
87cb694
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5270 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 232 232
Lines 8950 8952 +2
Branches 2334 2335 +1
=======================================
+ Hits 8848 8850 +2
Misses 43 43
Partials 59 59 ☔ View full report in Codecov by Sentry. |
lukastaegert
force-pushed
the
gh-5260-add-watch-file
branch
from
491d995 to
c811f23
Compare
|
This PR has been released as part of rollup@4.6.0. You can test it via |
1 participant
also trigger close hook in watch mode
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
this.addWatchFileinloadhook throws an error if manualChunks is used #5260Description
This removes any restrictions on
this.addWatchFileso that it can now be called in all hooks.Note that when
watch.skipWriteistrue, no hooks from the generate phase will be called andcloseBundlewill not be called.Last, we now no longer access
thisinthis.addWatchFile.