Skip to content

Error for armv7 musl build#5255

Merged
lukastaegert merged 3 commits intomasterfrom
error-for-arm-musl-build
Nov 18, 2023
Merged

Error for armv7 musl build#5255
lukastaegert merged 3 commits intomasterfrom
error-for-arm-musl-build

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Nov 17, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This will ensure we show a proper error when running on an armv7 Linux system that needs musl instead of a technical error. This will also point users to using the WASM build.

@vercel
Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview Nov 17, 2023 4:14pm

@github-actions
Copy link

github-actions bot commented Nov 17, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#error-for-arm-musl-build

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-hrhqvlbbe-rollup-js.vercel.app/repl/?pr=5255

@codecov
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1df8b49) 98.89% compared to head (5851edb) 98.87%.

Files Patch % Lines
native.js 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5255      +/-   ##
==========================================
- Coverage   98.89%   98.87%   -0.03%     
==========================================
  Files         232      232              
  Lines        8936     8941       +5     
  Branches     2333     2333              
==========================================
+ Hits         8837     8840       +3     
- Misses         40       42       +2     
  Partials       59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit 86bdd2b into master Nov 18, 2023
@lukastaegert lukastaegert deleted the error-for-arm-musl-build branch November 18, 2023 05:31
@github-actions
Copy link

This PR has been released as part of rollup@4.5.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant