Skip to content

add keyword input_text_into_prompt - #450

Merged
just-be-dev merged 13 commits into
masterfrom
unknown repository
Jul 21, 2015
Merged

add keyword input_text_into_prompt#450
just-be-dev merged 13 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jul 20, 2015

Copy link
Copy Markdown

add keyword input_text_into_prompt ( example from boakley )
fixes issue #292 "Add ability to type into a prompt"

add keyword input_text_into_prompt ( example from boakley )
fixes issue #292 "Add ability to type into a prompt"
@just-be-dev

Copy link
Copy Markdown
Contributor

We seriously didn't already have this? 0.o

@just-be-dev

Copy link
Copy Markdown
Contributor

Wow. Heh. Anyway, @ekasteel, it looks good to me. Can you add a test and update the changelog? Thanks!

@just-be-dev

Copy link
Copy Markdown
Contributor

Could you merge in master? There was an error that was causing tests to fail, but it should be fixed now.

@ghost

ghost commented Jul 21, 2015

Copy link
Copy Markdown
Author

not sure what went wrong. things look messy, I do not want the commits for the test to be part of the pull request ( at least not until I am sure they work fine )

@just-be-dev

Copy link
Copy Markdown
Contributor

It's not your changes that are failing, it's an issue with the newest version of selenium. Another PR already fixed the issue, so updating your PR should correct the tests.

Add test for keyword Input Text Into Prompt
@ghost

ghost commented Jul 21, 2015

Copy link
Copy Markdown
Author

the keyword now has a test which passes. looks fine to me
please note the example is from boakley and fixes issue #292 "Add ability to type into a prompt"

@just-be-dev

Copy link
Copy Markdown
Contributor

Looks good! Would you mind updating the change log? After that I'll merge it in.

Added new keyword Input Text Into Prompt (example from boakley). Fixes #292
@ghost

ghost commented Jul 21, 2015

Copy link
Copy Markdown
Author

change log updated

@just-be-dev

Copy link
Copy Markdown
Contributor

Thanks.

just-be-dev added a commit that referenced this pull request Jul 21, 2015
add keyword input_text_into_prompt
@just-be-dev
just-be-dev merged commit 2067aeb into robotframework:master Jul 21, 2015
@just-be-dev

Copy link
Copy Markdown
Contributor

Could you take a look at this?

https://travis-ci.org/rtomac/robotframework-selenium2library/jobs/72146078

I'm going to revert your changes for now, they're holding up a hotfix that we have to get out.

Edit: Unless I can figure them out pretty quickly. I'm going take another look at this after lunch.

@emanlove

Copy link
Copy Markdown
Member

This error is not occurring on my machine (Linux / Firefox 23). Not saying that we are good to go just that I am not seeing the error. This doesn't surprise me as I have seen other system differences.

I will note that the test for this isn't actually verifying anything. It should check to see that the name shows up on the page (as the test page is currently coded). Also this should probably be a part of the acceptance.keywords.javascript test suite and not necessarily it's own.

@just-be-dev

Copy link
Copy Markdown
Contributor

I'll make those changes. I think I fixed the error that Travis was running into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants