[feat] Add support for marking tests as expected failures#3481
Merged
vkarak merged 4 commits intoreframe-hpc:developfrom Jun 27, 2025
Merged
[feat] Add support for marking tests as expected failures#3481vkarak merged 4 commits intoreframe-hpc:developfrom
vkarak merged 4 commits intoreframe-hpc:developfrom
Conversation
7bbb18a to
0d5b5e4
Compare
teojgo
requested changes
Jun 18, 2025
8cb57af to
489e3b0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3481 +/- ##
===========================================
+ Coverage 91.13% 91.16% +0.02%
===========================================
Files 62 62
Lines 13132 13253 +121
===========================================
+ Hits 11968 12082 +114
- Misses 1164 1171 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5615f79 to
17d6122
Compare
teojgo
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main elements introduced by this PR are:
@xfaildecorator to mark a test as an expected sanity failure.xfail()builtin to mark reference tuples as expected performance failures.Two new test states are introduced which are also logged:
XFAILfor expected failures andXPASSfor unexpected passes.Design-wise the concept is the same as the one explained in #2378.
Implementation-wise there are two major changes:
reference_bounds()is introduced which is used to validate and calculate the absolute lower/upper bounds. This used to be internal toassert_reference()and now it's made public (maybe the docs there need a slight reorganization).pass,fail,xpassorxfail.For more details on how feature works macroscopically check the tutorial and the reference docs.
Closes #2378.