[feat] Add support for configure directory in CMake builds#3395
Merged
vkarak merged 7 commits intoreframe-hpc:developfrom Feb 26, 2025
Merged
[feat] Add support for configure directory in CMake builds#3395vkarak merged 7 commits intoreframe-hpc:developfrom
vkarak merged 7 commits intoreframe-hpc:developfrom
Conversation
mredenti
changed the title
CMake.configuredir to specify source directory in CMake builds
vkarak
requested changes
Feb 21, 2025
vkarak
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3359.
Changes:
configuredirtoConfigureBasedBuildSystem, making it available to all configure-based build systems (Autotools, CMake).CMake.emit_build_commandsto respectconfiguredir.configuredirdefinition fromAutotools, as it now inherits this property fromConfigureBasedBuildSystem.Now
CMake.configuredirallows users to specify the source directory explicitly, aligning withAutotools.configuredir.Why We Don't Use
-SAlthough CMake provides the
-Sflag to specify the source directory, this option was introduced in CMake 3.13. To maintain compatibility with older versions, this implementation does not use-Sexplicitly. Instead,configurediris passed as the last argument in thecmakecommand, which ensures compatibility with both older and newer CMake versions.Indeed, CMake v3.12 does not support the
-Sflag https://cmake.org/cmake/help/v3.12/manual/cmake.1.html but v3.13 does https://cmake.org/cmake/help/v3.13/manual/cmake.1.html