Skip to content

Remove unneeded composer.lock - #395

Merged
WyriHaximus merged 1 commit into
reactphp:masterfrom
clue-labs:lock
Dec 20, 2017
Merged

Remove unneeded composer.lock#395
WyriHaximus merged 1 commit into
reactphp:masterfrom
clue-labs:lock

Conversation

@clue

@clue clue commented Dec 20, 2017

Copy link
Copy Markdown
Member

This project is used as a library (if at all, see #348), so the composer.lock is not needed here. Removing this also allows testing newer versions limited by the constraints in our composer.json. A follow-up PR will update this version range.

Supersedes / closes #391

@jsor jsor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for non-locking I/O

@WyriHaximus
WyriHaximus merged commit 0656ae5 into reactphp:master Dec 20, 2017
@clue
clue deleted the lock branch December 20, 2017 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants