Docs/hooks api reference - #272
Merged
Merged
Conversation
ph1p
requested changes
Jan 3, 2023
ph1p
added
needs review from author
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
Co-authored-by: Phil <phil@capshake.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PReichetanz
commented
Jan 5, 2023
Co-authored-by: Phil <phil@capshake.com>
Contributor
Author
|
Hey @ph1p, I have agreed on almost all issues you have remarked; there are, however, three issues left where I am not sure how to handle them. Could you please have a look again so that we can discuss what do to here? Thank you very much again! |
Size ChangesDetails📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
Co-authored-by: Paul Reichetanz <33567019+PReichetanz@users.noreply.github.com>
ph1p
reviewed
Jan 5, 2023
Member
|
Thank you for the quick response (: I commented a little but after that it should be ready to merge |
Co-authored-by: Paul Reichetanz <33567019+PReichetanz@users.noreply.github.com>
ph1p
removed
the
needs review from author
Member
|
Sorry for the delay. All problems are solved now and we are ready to merge. Thank you! (: |
ph1p
approved these changes
Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translation for
Hooks API ReferenceAll comments and ideas for further improving the translation are very much appreciated!